utils/deps: always show missing deps#4876
utils/deps: always show missing deps#4876doronbehar wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
|
|
|
Please merge the commits to the develop branch. |
doronbehar
force-pushed
the
error-missing-deps
branch
from
031c922 to
1c5df61
Compare
Done. |
Bobholamovic
left a comment
Bobholamovic
left a comment
There was a problem hiding this comment.
Considering that is_extra_available is sometimes used only to check whether the extra is available in order to branch the logic, logging an error-level message here does not seem appropriate.
I suggest adding a parameter to is_extra_available to control whether an error-level log should be emitted. This flag can then be enabled in assertion-style functions such as require_extra, so that users can still receive helpful diagnostic information when necessary.
When first trying out paddlex, it can be hard to figure out how to increase the logging verbosity. If there are missing dependencies and this raises an error, seeing the exact list is helpful.
doronbehar
force-pushed
the
error-missing-deps
branch
from
1c5df61 to
78fdb9b
Compare
|
OK I see this makes sense, I wasn't aware that |
4 participants
When trying to use PaddleX on NixOS, which doesn't allow imperative installation of Python packages with
pip, I found this change to be useful, and thought that other users might benefit from it. Original commit message: